r197224 - Enabling thumb2 mode used to force support for armv6t2. Replace this

Joerg Sonnenberger joerg at britannica.bec.de
Mon Dec 16 08:42:56 PST 2013


On Mon, Dec 16, 2013 at 04:15:47PM -0000, Bernie Ogden wrote:
> Perhaps I'm just failing to understand, but I don't understand why you need
> to add an explicit CPU to all of these tests. If you're testing that CPUs
> with Thumb2 also have V6T2Ops then wouldn't it be better to add a single
> test that explicitly checks for this?

Before, enabling Thumb2 implicitly changed the CPU to have V6T2Ops etc.
It no longer does. To ease the transition somewhat, it asserts that the
current mode makes sense. For that reason and to produce the same output
as before, the tests were updated to include the CPU they were
effectively using already.

Joerg



More information about the llvm-commits mailing list