r197224 - Enabling thumb2 mode used to force support for armv6t2. Replace this

Tim Northover t.p.northover at gmail.com
Mon Dec 16 08:33:03 PST 2013

Hi Bernie,

> Perhaps I'm just failing to understand, but I don't understand why you need
> to add an explicit CPU to all of these tests. If you're testing that CPUs
> with Thumb2 also have V6T2Ops then wouldn't it be better to add a single
> test that explicitly checks for this?

I haven't experimented, but I think the problem is more that after
Joerg's change, just giving "-mattr=+thumb2" to llc would leave it in
an inconsistent (or at least very odd) state. What's really desired in
most cases is "a v6T2 processor", so he just went and added it.

An alternative would have been "-mattr=+thumb2,+v6t2". I don't know
why he picked the one he did; perhaps even those two attributes aren't
a sensible choice alone.



More information about the llvm-commits mailing list