[PATCH] ARM IAS: support .inst directive

[Saleem Abdulrasool]

On Sunday, December 15, 2013, Joerg Sonnenberger wrote:

> On Sat, Dec 14, 2013 at 10:06:24PM -0800, Saleem Abdulrasool wrote:
> > @@ -7809,6 +7811,12 @@
> >      return parseDirectiveRegSave(DirectiveID.getLoc(), false);
> >    else if (IDVal == ".vsave")
> >      return parseDirectiveRegSave(DirectiveID.getLoc(), true);
> > +  else if (IDVal == ".inst")
> > +    return parseDirectiveInst(DirectiveID.getLoc(), 0);
> > +  else if (IDVal == ".inst.n")
> > +    return parseDirectiveInst(DirectiveID.getLoc(), 2, 'n');
> > +  else if (IDVal == ".inst.w")
> > +    return parseDirectiveInst(DirectiveID.getLoc(), 4, 'w');
> >    return true;
> >  }
> >
>
> What do you need the third argument for? It seems to be completely
> redundant with the width.


You are correct that it is redundant with the second parameter.  I could
recover the suffix in parseInstDirective.  I did that and then decided to
pass it down.  I suppose I can just calculate the width in the parse
function and remove the second parameter.  The suffix is only needed for
the ASM streamer, where I couldn't determine whether the current mode is
ARM or Thumb.

Joerg
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <javascript:;>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131215/ec8c50f2/attachment.html>