[llvm] r197119 - Check for null pointer before dereferencing. A careless typo on my part.

David Blaikie dblaikie at gmail.com
Thu Dec 12 16:42:12 PST 2013

On Thu, Dec 12, 2013 at 3:10 PM, reed kotler <rkotler at mips.com> wrote:
> Yes. I will make one. It was in test-suite but I need to whittle it down
> because it was
> too big. I will file a local but at Mips for myself to make sure I don't
> forget to push it.

Thanks. Please reply to this thread with the revision that includes
the test, when it is committed (and mention this revision in the
commit message for the test) - so we can find the tests/code when we
need to.

For future reference, usually we try to include the test in the same
patch - it makes it easier to keep track of which tests address which
bits of code and to ensure that code is appropriately tested, etc.

- David

More information about the llvm-commits mailing list