[patch] Simplify the datalayout strings by using the defaults

David Peixotto dpeixott at codeaurora.org
Thu Dec 12 10:28:29 PST 2013

Sorry I'm joining the conversation a bit late, but these look like good changes. 

Are you planning to make the corresponding refactoring/defaulting changes to the data layout strings in clang (e.g. DescriptionString in lib/Basic/Targets.cpp)?

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Rafael EspĂ­ndola
> Sent: Thursday, December 12, 2013 9:52 AM
> To: Rafael EspĂ­ndola; llvm-commits; Richard Sandiford
> Subject: Re: [patch] Simplify the datalayout strings by using the defaults
> > Looks good to me, thanks.  If we don't want "a0:" to be used then
> > maybe it would be worth changing:
> >
> > -  ``a0:0:64`` - aggregates are 64-bit aligned
> >
> > in LangRef.rst too.
> Thanks. I have committed the bits That Richard and Tim reviewed or
> suggested.
> A rebased patch with the remaining targets is attached.
> Cheers,
> Rafael

More information about the llvm-commits mailing list