[llvm] r196996 - Move mips' datalayout computation out of line and add comments.

Richard Sandiford rsandifo at linux.vnet.ibm.com
Wed Dec 11 03:03:19 PST 2013

Rafael Espindola <rafael.espindola at gmail.com> writes:
> +  // 32 bit registers are always available and the stack is at least 64 bit
> +  // aligned. On N64 64 bit registers are also available and the stack is
> +  // 128 bit aligned.
> +  if (ST.isABI_N64())
> +    Ret += "-n32:64-S128";
> +  else
> +    Ret += "-n32-S64";

n32 also has 64-bit registers and a 128-bit stack alignment, so I wonder
whether this should include ST.isABI_N32()?

That's obviously a preexisting problem (if it is a problem) since your
patch doesn't change the behaviour.  It just stood out more with the
new comments.


More information about the llvm-commits mailing list