[PATCH] [stack protector] Improved data layout rules, WIP, part 3

Bill Wendling isanbard at gmail.com
Tue Dec 10 23:08:26 PST 2013

  This looks good so far. I have one question on your comment here:

  //The actual layout is roughly the same - i.e., only LargeArray stack objects will be placed near the canary. Everything else is laid out normally. Note that the stack layout is not be identical in all cases because the current heuristic used for layout (MayNeedSP) misses structures that contain large arrays.//

  I'm assuming that you mean the layout won't be the same as it was before your change? I just want to make sure that, once your changes go in, the output will be deterministic. :-)

Comment at: include/llvm/CodeGen/StackProtector.h:23
@@ -22,2 +22,3 @@
 #include "llvm/ADT/ValueMap.h"
+#include "llvm/Analysis/Dominators.h"
 #include "llvm/Pass.h"
Is this #include necessary in the .h file? I don't see other changes in here where the forward declaration doesn't work.


More information about the llvm-commits mailing list