[compiler-rt] r196802 - Revert three patches which were committed without explicit contribution

Jakub Jelinek jakub at redhat.com
Tue Dec 10 10:34:27 PST 2013


On Tue, Dec 10, 2013 at 08:22:22AM -0600, Peter Bergner wrote:
> On Mon, 2013-12-09 at 19:25 +0000, Chandler Carruth wrote:
> > Author: chandlerc
> > Date: Mon Dec  9 13:25:51 2013
> > New Revision: 196802
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=196802&view=rev
> > Log:
> > Revert three patches which were committed without explicit contribution
> > by their authors.
> > 
> > This may break builds where others added code relying on these patches,
> > but please *do not* revert this commit. Instead, we will prepare patches
> > which fix the failures.
> > 
> > Reverts the following commits:
> > r168306: "[asan] support x32 mode in the fast stack unwinder. Patch by H.J. Lu"
> > r168356: "[asan] more support for powerpc, patch by Peter Bergner"
> > r196489: "[sanitizer] fix the ppc32 build (patch by Jakub Jelinek)"
> 
> 
> As one of the authors of these patches, what is the rational for reverting them?

Yeah.  Especially when other contributions to compiler-rt from me weren't
reverted and I'm not aware what the differences between those submissions
exactly were.  All of them have been explicit constributions IMNSHO.

	Jakub



More information about the llvm-commits mailing list