[llvm] r196858 - Fix PR18162 - Incorrect assertion assumed that the SDValue resno is zero.

Nadav Rotem nrotem at apple.com
Mon Dec 9 17:13:59 PST 2013


Author: nadav
Date: Mon Dec  9 19:13:59 2013
New Revision: 196858

URL: http://llvm.org/viewvc/llvm-project?rev=196858&view=rev
Log:
Fix PR18162 - Incorrect assertion assumed that the SDValue resno is zero.

Added:
    llvm/trunk/test/CodeGen/X86/pr18162.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=196858&r1=196857&r2=196858&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Mon Dec  9 19:13:59 2013
@@ -9859,7 +9859,7 @@ SDValue DAGCombiner::visitCONCAT_VECTORS
   if (N->getNumOperands() == 2 &&
       N->getOperand(1)->getOpcode() == ISD::UNDEF) {
     SDValue In = N->getOperand(0);
-    assert(In->getValueType(0).isVector() && "Must concat vectors");
+    assert(In.getValueType().isVector() && "Must concat vectors");
 
     // Transform: concat_vectors(scalar, undef) -> scalar_to_vector(sclr).
     if (In->getOpcode() == ISD::BITCAST &&

Added: llvm/trunk/test/CodeGen/X86/pr18162.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/pr18162.ll?rev=196858&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/X86/pr18162.ll (added)
+++ llvm/trunk/test/CodeGen/X86/pr18162.ll Mon Dec  9 19:13:59 2013
@@ -0,0 +1,27 @@
+; RUN: llc < %s
+
+; Make sure we are not crashing on this one.
+
+target triple = "x86_64-unknown-linux-gnu"
+
+%"Iterator" = type { i32* }
+
+declare { i64, <2 x float> } @Call() 
+declare { i64, <2 x float> }* @CallPtr() 
+
+define { i64, <2 x float> } @Foo(%"Iterator"* %this) {
+entry:
+  %retval = alloca i32
+  %this.addr = alloca %"Iterator"*
+  %this1 = load %"Iterator"** %this.addr
+  %bundle_ = getelementptr inbounds %"Iterator"* %this1, i32 0, i32 0
+  %0 = load i32** %bundle_
+  %1 = call { i64, <2 x float> } @Call()
+  %2 = call { i64, <2 x float> }* @CallPtr()
+  %3 = getelementptr { i64, <2 x float> }* %2, i32 0, i32 1
+  %4 = extractvalue { i64, <2 x float> } %1, 1
+  store <2 x float> %4, <2 x float>* %3
+  %5 = load { i64, <2 x float> }* %2
+  ret { i64, <2 x float> } %5
+}
+





More information about the llvm-commits mailing list