[PATCH][darwin] revert to .weak_definition on darwin<10

Jim Grosbach grosbach at apple.com
Mon Dec 9 16:02:32 PST 2013

On Dec 9, 2013, at 2:41 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> On 6 December 2013 14:22, David Fang <fang at csl.cornell.edu> wrote:
>> It seems I am not very good at attaching patches.
>> How does this look?
> MCAsmInfo has a hasWeakDefDirective. I would suggest adding a
> hasWeakDefCanBeHiddenDirective instead of inlining the check on the
> AsmPrinter.
> I will let Grosbach comment on which targets/versions we should do this for.

<10 seems reasonable to me.

I don’t like using the target version for this, but as the FIXME indicates, there’s not a better answer available right now, so pragmatically this will get things working. It’s also simple enough that when/if we do get a better answer, this doesn’t make it harder to do so.

More information about the llvm-commits mailing list