[llvm] r196726 - Cleaning up of prologue/epilogue code for Mips16. First step

reed kotler rkotler at mips.com
Mon Dec 9 13:55:22 PST 2013


On 12/09/2013 01:54 PM, Eric Christopher wrote:
> It's a simple and isolated one line change, it's better if you make it
> an isolated commit so that looking through the history doesn't confuse
> it with your next commit.
okay. i will do it that way then.
> -eric
>
> On Mon, Dec 9, 2013 at 1:49 PM, reed kotler <rkotler at mips.com> wrote:
>> Good point. Just an oversight. I'll take care of this in my next putback.
>>
>> I'm cleaning up all of this prologue/epilogue code for mips16.
>>
>>
>> On 12/09/2013 01:35 PM, Eric Christopher wrote:
>>>> -      BuildMI(MBB, I, DL, get(Mips::SaveRaF16)).addImm(FrameSize);
>>>> +      //BuildMI(MBB, I, DL, get(Mips::SaveRaF16)).addImm(FrameSize);
>>>> +      BuildMI(MBB, I, DL, get(Mips::SaveX16)).addReg(Mips::RA).
>>>> +              addReg(Mips::S0).
>>>> +              addReg(Mips::S1).addReg(Mips::S2).addImm(FrameSize);
>>> Confusing commented out line.
>>>
>>> -eric
>>
>>





More information about the llvm-commits mailing list