[PATCH] Fix a crash that occurs when PWD is invalid.

Eric Christopher echristo at gmail.com
Mon Dec 9 12:01:51 PST 2013


Out of curiosity why isn't it able to get a compilation dir?

-eric

On Mon, Dec 9, 2013 at 11:41 AM, Andrew Trick <atrick at apple.com> wrote:
> MCJIT needs to be able to run in hostile environments, even when PWD
> is invalid. There's no need to crash MCJIT in this case.
>
> If we do want to guarantee valid CompilationDir, that should be done
> only for clients of getCompilationDir(). This is as simple as checking
> for an empty string.
>
> The obvious fix is to simply leave MCContext's CompilationDir empty
> when PWD can't be determined. The only behavioral difference would be
> that EmitGenDwarfInfo would output an empty string when recording the
> working dir for the assembly output.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list