[PATCH] Zorg: getLLDBuildFactory() now takes an optional 'env' parameter

Mikael Lyngvig mikael at lyngvig.org
Mon Dec 9 11:34:13 PST 2013

The patch has been updated and I am re-submitting everything I've submitted
to Galina as well so that it goes through a full peer review.

Phew, thank you a ton for catching that!

As far as the CC and CXX environment variables goes, I did it to retain
backwards compatibility with the existing three LLD builders:

-                               env={
-                                    'CXX': "clang++",
-                                    'C':   "clang"},
+                               env=merged_env,

So they already got overriden, I have simply made the override overriddable
:-)  Now you can specify that you want to use ccache in the env argument,
something you could not do before.  I am also going to use ccache.  I bet
your lld builds haven't been using ccache, even if you thought they did.

Please also notice that my builder uses GNU Gold - also through an override
of env.

-- Mikael

2013/12/9 Dmitri Gribenko <gribozavr at gmail.com>

> On Sat, Dec 7, 2013 at 2:48 AM, Mikael Lyngvig <mikael at lyngvig.org> wrote:
> > I am finally getting somewhere on my project of setting up a PowerPC lld
> > builder and for that I need this patch to be included in Zorg.  It simply
> > adds the 'env' parameter to getLLDBuildFactory() that most of the other
> > build factory functions have.
> +                   'C'    : "clang",
> This should be 'CC'.
> Also, I think that this change might disable ccache on my builders,
> because this change overrides system's CC and CXX when the environment
> configured in zorg is empty.  I think that there should be no defaults
> for CC and CXX.  These can be overridden in per-builder configuration.
> Dmitri
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131209/55c6824d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: zorg-lld-builder.patch
Type: application/octet-stream
Size: 4269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131209/55c6824d/attachment.obj>

More information about the llvm-commits mailing list