[PATCH] Support Android NDK (which has neither futimes nor futimens)

Neil Henning llvm at neil-henning.co.uk
Mon Dec 9 01:37:00 PST 2013

Hey all,

Thanks for the comments! I was reluctant to make it work on any 
non-Android UNIX platform without either futimes or futimens simply 
because I don't have the targets to hand to test that on!

In terms of making the call a no-op - would it be acceptable to then 
make it work on non-Android UNIX platforms like Pete Cooper suggested? 
That way I wouldn't have to include any mention of ANDROID at all in the 
patch, and the expected behaviour of the function 
setLastModificationAndAccessTime would become 'Set the modification and 
access time if we can, if not no problem!'



On 08/12/2013 02:21, Rafael EspĂ­ndola wrote:
>> This needs a cost vs. benefit analysis before going any further...
>> Cost:
>>    Maintaining direct Linux syscalls is a burden to the project.
>> Benefits:
>>    Adding the syscall may provide command-line users on older Android
>> versions some limited support for the llvm-ar tool's obscure -o option to
>> preserve timestamps.
>> On balance, I'd go for making this a no-op :-)
> Even better :-) (assuming people are not somehow depending on -o).
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

More information about the llvm-commits mailing list