[llvm][Patch 1/3] ppc-darwin AsmParser Base implementation.

David Fang fang at csl.cornell.edu
Sat Dec 7 23:49:42 PST 2013


Checking for wrong use of .machine seems like a good idea.

It occurred to me that there's no real compelling reason to reject ELF 
syntax for darwin targets, nor darwin-syntax for ELF targets.  Though 
strange it seems, it was kind of novel having the hello-reloc.s test 
written in ELF syntax be targeted to darwin object generation. While I 
agree that syntax should not be mixed within a single assembly file, is it 
really necessary to restrict the syntax to the target?  It is *just* 
syntax.

David

> On 5 Dec 2013, at 23:59, David Fang wrote:
>
>> Attached is the change to the aforementioned test case.
>> Consider it patch part 4.
>
> LGTM
> .. we still need to add a couple more tests to check for wrong use of .machine directives.
>
> Iain
>

-- 
David Fang
http://www.csl.cornell.edu/~fang/




More information about the llvm-commits mailing list