[llvm][Patch 2/3] ppc-darwin AsmParser Base implementation.

[Iain Sandoe]

Hi Ulrich,

thanks for reviewing!

On 6 Dec 2013, at 13:11, Ulrich Weigand wrote:

> Iain Sandoe <iain at codesourcery.com> wrote:
> 
>> Part 2 Enables parsing of {r,f,v}XX as register identifiers.
> 
> +    if(isDarwin()) {
> 
> I think coding style is to have a space after "if" (occurs
> in a couple of places).
fixed.

> Does the Darwin assembler really *prohibit* use of
> plain integers to identify registers in addresses?


indeed, I guess the fork happened before '-mregnames' was invented.

is the revised version ok for commit?
Iain
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ppc-darwin-asm-parser-part2v2-diff.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131207/4a2bd81a/attachment.txt>