[PATCH] Fix inlining to not produce duplicate landingpad clauses

Bill Wendling morbo at google.com
Fri Dec 6 12:09:58 PST 2013


Oh...maybe I did. Sorry about that. :-) I'll look at it more closely tonight.

-bw

On Fri, Dec 6, 2013 at 12:06 PM, Mark Seaborn <mseaborn at chromium.org> wrote:
> [For patch http://llvm-reviews.chandlerc.com/D2342]
>
> On the other thread, Bill Wendling wrote:
>>
>> For the original patch, John McCall might be the best person to review it.
>> I believe that's his code originally.
>
>
> OK, CC'ing John McCall, although from the version history it does look like
> you wrote it, Bill.
>
> This change (from 2011) first added the addClause() calls to
> HandleCallsInBlockInlinedThroughInvoke():
> http://llvm.org/viewvc/llvm-project?view=revision&revision=137576
>
> Then this change (from March 2013) added the addClause() calls to
> forwardResume():
> http://llvm.org/viewvc/llvm-project?view=revision&revision=177680
> -- though this had some de-duplication logic (removed soon after in r177757)
> which I think would have prevented the duplicated landingpad clauses I'm
> getting at the moment.
>
> Cheers,
> Mark
>



More information about the llvm-commits mailing list