[PATCH] Fix inlining to not produce duplicate landingpad clauses

Mark Seaborn mseaborn at chromium.org
Fri Dec 6 12:06:37 PST 2013


[For patch http://llvm-reviews.chandlerc.com/D2342]

On the other thread, Bill Wendling wrote:

> For the original patch, John McCall might be the best person to review it.
> I believe that's his code originally.


OK, CC'ing John McCall, although from the version history it does look like
you wrote it, Bill.

This change (from 2011) first added the addClause() calls to
HandleCallsInBlockInlinedThroughInvoke():
http://llvm.org/viewvc/llvm-project?view=revision&revision=137576

Then this change (from March 2013) added the addClause() calls
to forwardResume():
http://llvm.org/viewvc/llvm-project?view=revision&revision=177680
-- though this had some de-duplication logic (removed soon after in
r177757) which I think would have prevented the duplicated landingpad
clauses I'm getting at the moment.

Cheers,
Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131206/f2c628fa/attachment.html>


More information about the llvm-commits mailing list