[PATCH] Fix instcombine's folding of select into phi nodes for ConstantExpr

Duncan P. N. Exon Smith dexonsmith at apple.com
Fri Dec 6 12:00:52 PST 2013


On Dec 6, 2013, at 11:20 AM, Justin Bogner <mail at justinbogner.com> wrote:

> How tricky is it to come up with a test case that doesn't rely on us
> failing to constant fold the icmp here? This one seems a bit fragile.

Thanks for the suggestion.  The test in the updated patch uses extern_weak globals in the icmp, which should *not* be constant folded.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: instcombine-phi-select-constexpr-2.patch
Type: application/octet-stream
Size: 2027 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131206/39e59e61/attachment.obj>


More information about the llvm-commits mailing list