[PATCH] Fix instcombine's folding of select into phi nodes for ConstantExpr

Bill Wendling isanbard at gmail.com
Fri Dec 6 11:09:52 PST 2013


This was the same approach I was taking. Approved unless others have an
objection.

LGTM.

-bw


On Fri, Dec 6, 2013 at 9:43 AM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> This patch fixes PR18143.
>
> InstCombiner::FoldOpIntoPhi assumed that Constant::isNullValue can check
> for false, but this isn’t true for ConstantExpr.  It appears that this bug
> was latent until some time after 3.2, when the ConstantExpr in question
> stopped being constant-folded.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131206/c1ecc86c/attachment.html>


More information about the llvm-commits mailing list