[lld] r196505 - Use !! to convert to a boolean value.

Nick Kledzik kledzik at apple.com
Thu Dec 5 10:58:14 PST 2013


On Dec 5, 2013, at 5:11 AM, Rui Ueyama <ruiu at google.com> wrote:

> Author: ruiu
> Date: Thu Dec  5 07:11:33 2013
> New Revision: 196505
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=196505&view=rev
> Log:
> Use !! to convert to a boolean value.
> 
> Modified:
>    lld/trunk/include/lld/ReaderWriter/PECOFFLinkingContext.h
> 
> Modified: lld/trunk/include/lld/ReaderWriter/PECOFFLinkingContext.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/PECOFFLinkingContext.h?rev=196505&r1=196504&r2=196505&view=diff
> ==============================================================================
> --- lld/trunk/include/lld/ReaderWriter/PECOFFLinkingContext.h (original)
> +++ lld/trunk/include/lld/ReaderWriter/PECOFFLinkingContext.h Thu Dec  5 07:11:33 2013
> @@ -230,11 +230,7 @@ public:
>     return ArrayRef<uint8_t>(p, p + array.size());
>   }
> 
> -  virtual bool hasInputGraph() {
> -    if (_inputGraph)
> -      return true;
> -    return false;
> -  }
> +  virtual bool hasInputGraph() { return !!_inputGraph; }
This seems rather obtuse.   Why not:
     virtual bool hasInputGraph() { return (_inputGraph != nullptr); }






More information about the llvm-commits mailing list