[llvm] r196178 - Make ranges and range lists be a discrete entity that can be located

Eric Christopher echristo at gmail.com
Wed Dec 4 13:54:14 PST 2013


>> Possibly. I was trying to avoid overlapping names with common data
>> structures as well. :\
>>
>> Not sure what's more clear.
>
> Honestly it'd probably be useful to put all this stuff in a debuginfo
> namespace or something (& a corresponding directory) - the mismatch
> between file names and the classes they contain is already weird.
>
> To reduce ambiguity I'd probably err towards an 'Address' prefix,
> perhaps ("AddressRange", "AddressRangeSet", "AddressRangeSets"
> (plurality versus a container suffix is also interesting - I don't
> think the standard gives us a term for the "set of sets")).
>

Seems reasonable. I'll throw it on the "to refactor" list.

> And admittedly the confusion of using "set" for a structure backed by
> a vector is questionable.
>

Truth.

-eric



More information about the llvm-commits mailing list