[PATCH] cmake: Export symbols in all tools that support plugins.

[Reid Kleckner]

Can you make sure that this doesn't slow down 'make check' on Linux too
much?  I worry that we --export-dynamic for llc, lots of symbol uses will
become dynamic PLT lookups and startup time will regress.


On Tue, Dec 3, 2013 at 7:57 PM, Rafael Espíndola <rafael.espindola at gmail.com
> wrote:

> LGTM for llc and lli, but I see TOOL_NO_EXPORTS in
> tools/llvm-stress/Makefile.  We should also remove TOOL_NO_EXPORTS
> from llvm-stress/Makefile if it needs plugins.
>
> On 3 December 2013 18:20, Will Dietz <w at wdtz.org> wrote:
> > Fixes undefined reference errors when attempting to load plugins into
> > these tools.
> >
> > For example, VMKit uses an llc plugin that presently fails to load
> > without this fix.
> > Other tools (lli, llvm-stress) were found by grep'ing for use of
> PluginLoader.h.
> >
> > Patch attached.
> >
> > ~Will
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131204/3f3e681a/attachment.html>