[PATCH] remove std::string in dr_init for optimized hybrid execution

Reid Kleckner rnk at google.com
Wed Dec 4 10:30:42 PST 2013


Can this be rewritten with repeated strcmp instead, or will msan intercept
it?

There's also much more STL usage in here...


On Wed, Dec 4, 2013 at 10:16 AM, Qin Zhao <zhaoqin at google.com> wrote:

> Hi eugenis,
>
> remove std::string in dr_init for optimized hybrid execution
>
> http://llvm-reviews.chandlerc.com/D2330
>
> Files:
>   msandr.cc
>
> Index: msandr.cc
> ===================================================================
> --- msandr.cc
> +++ msandr.cc
> @@ -792,6 +792,8 @@
>    drmgr_init();
>    drutil_init();
>
> +#ifndef MSANDR_NATIVE_EXEC
> +  // We should use drconfig to ignore these applications.
>    std::string app_name = dr_get_application_name();
>    // This blacklist will still run these apps through DR's code cache.
>  On the
>    // other hand, we are able to follow children of these apps.
> @@ -802,6 +804,7 @@
>        app_name == "sh" || app_name == "true" || app_name == "exit" ||
>        app_name == "yes" || app_name == "echo")
>      return;
> +#endif /* !MSANDR_NATIVE_EXEC */
>
>    drsys_options_t ops;
>    memset(&ops, 0, sizeof(ops));
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131204/1077ac46/attachment.html>


More information about the llvm-commits mailing list