[PATCH] Move VFP4 predicate inside UseFusedMAC

Daniel Stewart stewartd at codeaurora.org
Wed Dec 4 08:41:07 PST 2013


Here's the patch that simply adds the check for VFP4 to UseFusedMAC.

Thanks for the clarification Tim, I appreciate it. 

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: Wednesday, December 04, 2013 11:32 AM
To: Daniel Stewart
Cc: llvm-commits
Subject: Re: [PATCH] Move VFP4 predicate inside UseFusedMAC

> Shouldn't UseFusedMAC still check for VFP4 inside its predicate, 
> rather than relying on the instruction to include HasVF4 inside it's 
> predicate checks? Just to ensure safety and be in line with the 
> DontUseFusedMAC? Or am I missing something else?

I think that sounds like a good idea, particularly making the two predicates
complimentary. I'd be very surprised if I found out they weren't.

Cheers.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-UseFusedMAC-directly-depends-on-VFP4.patch
Type: application/octet-stream
Size: 1221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131204/f4acef4c/attachment.obj>


More information about the llvm-commits mailing list