[PATCH][ARM] Added support for krait cpu

Renato Golin renato.golin at linaro.org
Wed Dec 4 00:17:36 PST 2013


On 4 December 2013 00:00, Ana Pazos <apazos at codeaurora.org> wrote:
> These patches add support for krait cpu in Clang and LLVM.

Hi Ana,

A few comments:

-  if (CPUString != "generic")
+  if (CPUString != "generic" && CPUString != "krait")
     ATS.emitTextAttribute(ARMBuildAttrs::CPU_name, CPUString);

I wonder why no other named CPU had to do this. I'm not particularly
comfortable with that.

About the Clang patch, would be good if you could include other tests
to match cpu->arch. (test/Driver/arm-cortex-cpus.c and friends).

cheers,
--renato



More information about the llvm-commits mailing list