[llvm] r196288 - Reland 196270 "Generalize debug info / EH emission in AsmPrinter"

[Tom Stellard]

On Tue, Dec 03, 2013 at 11:03:18PM +0400, Timur Iskhodzhanov wrote:
> 2013/12/3 Eric Christopher <echristo at gmail.com>
> 
> > > +  /// Please note that some AsmPrinter implementationss may not call
> >
> > "implementations"
> >
> 
> Oops! r196304
> 
>  > +  /// beginFunction at all.
> >
> > Wat? They call endFunction but not beginFunction?
> 
> 
> +Tom
> You might want to revisit how AMDGPUAsmPrinter interacts with DwarfDebug
> through AsmPrinter.
> 

Can you give me a little more background on the issue?  I don't know
anything about DwarfDebug and if R600 is using it, then it is probably
an accident.

-Tom

> 
> > -eric
> >

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits