[PATCH] Add support for parsing ARM symbol variants on ELF targets

David Peixotto dpeixott at codeaurora.org
Mon Dec 2 14:32:53 PST 2013


> There's a FIXME in include/llvm/MC/MCExpr.h saying we'd like to move
> towards eliminating the VK_ARM_* types (where possible, obviously
> TARGET1 and so on are ARM-specific and would remain).
> 
> This patch seems like it's most of the way there: the
> UseParenForSymbolVariant is just the extra bit of information that's
> needed to eliminate the distinction. Did you investigate what would be
> needed to perform that merge at the same time?

I did notice that FIXME. I did not investigate if this patch provides the
necessary mechanism to remove the arm specific VK types, mostly out of
ignorance of why that distinction was there to begin with. It sounds like
you are suggesting that the distinction was fairly superficial and mostly
related to printing them correctly. If that's the case then I think we
should be able to remove most of the arm-specific variants. 

Let me look into it.
 




More information about the llvm-commits mailing list