[PATCH] Add tests for profile sample file parsing

Sean Silva chisophugis at gmail.com
Wed Nov 27 16:45:20 PST 2013


Fyi, the convention for FileCheck labels is hyphen-separated caps LIKE-THIS

On Nov 27, 2013 5:17 PM, "Diego Novillo" <dnovillo at google.com> wrote:

Hi chandlerc,


The profile file parser needed some tests for its parsing actions.
This adds tests for each of the error messages emitted by the parser.


http://llvm-reviews.chandlerc.com/D2282

Files:
  test/Transforms/SampleProfile/Inputs/bad_fn_header.prof
  test/Transforms/SampleProfile/Inputs/bad_sample_line.prof
  test/Transforms/SampleProfile/Inputs/missing_num_syms.prof
  test/Transforms/SampleProfile/Inputs/missing_samples.prof
  test/Transforms/SampleProfile/Inputs/missing_symtab.prof
  test/Transforms/SampleProfile/Inputs/syntax.prof
  test/Transforms/SampleProfile/syntax.ll

Index: test/Transforms/SampleProfile/Inputs/bad_fn_header.prof
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/Inputs/bad_fn_header.prof
@@ -0,0 +1,6 @@
+symbol table
+1
+empty
+empty:100:BAD
+0: 0
+1: 100
Index: test/Transforms/SampleProfile/Inputs/bad_sample_line.prof
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/Inputs/bad_sample_line.prof
@@ -0,0 +1,6 @@
+symbol table
+1
+empty
+empty:100:0:1
+0: 0
+1: BAD
Index: test/Transforms/SampleProfile/Inputs/missing_num_syms.prof
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/Inputs/missing_num_syms.prof
@@ -0,0 +1,5 @@
+symbol table
+empty
+empty:100:0:1
+0: 0
+1: 100
Index: test/Transforms/SampleProfile/Inputs/missing_samples.prof
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/Inputs/missing_samples.prof
@@ -0,0 +1,6 @@
+symbol table
+1
+empty
+empty:100:0:10
+0: 0
+1: 100
Index: test/Transforms/SampleProfile/Inputs/missing_symtab.prof
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/Inputs/missing_symtab.prof
@@ -0,0 +1,5 @@
+1
+empty
+empty:100:0:1
+0: 0
+1: 100
Index: test/Transforms/SampleProfile/Inputs/syntax.prof
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/Inputs/syntax.prof
@@ -0,0 +1,6 @@
+symbol table
+1
+empty
+empty:100:0:2
+0: 0
+1: 100
Index: test/Transforms/SampleProfile/syntax.ll
===================================================================
--- /dev/null
+++ test/Transforms/SampleProfile/syntax.ll
@@ -0,0 +1,19 @@
+; RUN: not opt < %s -sample-profile
-sample-profile-file=%S/Inputs/syntax.prof 2>&1 | FileCheck
-check-prefix=NO_DEBUG %s
+; RUN: not opt < %s -sample-profile -sample-profile-file=missing.prof 2>&1
| FileCheck -check-prefix=MISSING_FILE %s
+; RUN: not opt < %s -sample-profile
-sample-profile-file=%S/Inputs/missing_symtab.prof 2>&1 | FileCheck
-check-prefix=MISSING_SYMTAB %s
+; RUN: not opt < %s -sample-profile
-sample-profile-file=%S/Inputs/missing_num_syms.prof 2>&1 | FileCheck
-check-prefix=MISSING_NUM_SYMS %s
+; RUN: not opt < %s -sample-profile
-sample-profile-file=%S/Inputs/bad_fn_header.prof 2>&1 | FileCheck
-check-prefix=BAD_FN_HEADER %s
+; RUN: not opt < %s -sample-profile
-sample-profile-file=%S/Inputs/bad_sample_line.prof 2>&1 | FileCheck
-check-prefix=BAD_SAMPLE_LINE %s
+; RUN: not opt < %s -sample-profile
-sample-profile-file=%S/Inputs/missing_samples.prof 2>&1 | FileCheck
-check-prefix=MISSING_SAMPLES %s
+
+define void @empty() {
+entry:
+  ret void
+}
+; NO_DEBUG: LLVM ERROR: No debug information found in function empty
+; MISSING_FILE: LLVM ERROR: Could not open profile file missing.prof: No
such file or directory
+; MISSING_SYMTAB: LLVM ERROR: {{.*}}missing_symtab.prof:1: Expected
'symbol table', found 1
+; MISSING_NUM_SYMS: LLVM ERROR: {{.*}}missing_num_syms.prof:2: Expected a
number, found empty
+; BAD_FN_HEADER: LLVM ERROR: {{.*}}bad_fn_header.prof:4: Expected
'mangled_name:NUM:NUM:NUM', found empty:100:BAD
+; BAD_SAMPLE_LINE: LLVM ERROR: {{.*}}bad_sample_line.prof:6: Expected
'mangled_name:NUM:NUM:NUM', found 1: BAD
+; MISSING_SAMPLES: LLVM ERROR: {{.*}}missing_samples.prof:6: Unexpected
end of file

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131127/4d20856b/attachment.html>


More information about the llvm-commits mailing list