[PATCH][AArch64] Add llvm-mc test for asm code generated from all LLVM IR tests

Jiangning Liu liujiangning1 at gmail.com
Sun Dec 1 19:54:04 PST 2013


I'm not fully convinced by Tim's explanation yet, so could you please
provide more explanation?

The key point of this improvement is to enlarge the testing coverage. We
don't really have a mechanism to check if all of the code generated in
CodeGen can pass MClayer yet.

It would be also OK if we can provide a general mechanism to ask the asm
result generated by llc in CodeGen to pass MC test.

This is kind of test can obviously expose some bugs, and those bugs could
be caused by either incorrect pattern match of pattern match with loose

I think it is not always easy to cover all of the scenarios in MCLayer
test, and particularly it's hard to cover every corner of negative test
scenarios. Enlarging testing coverage should be helpful to build a robust
compiler infrastructure, right?

As I mentioned above, we did find bugs using this test. Also, this kind of
test should be very fast, and I don't think it would
increase regression test time.

Looking forward to your response!


2013/11/28 Tim Northover <t.p.northover at gmail.com>

> Hi Jiangning,
> I think this might be a layering violation (I've CCed Jim Grosbach,
> who's pretty much the authority). I know that object file tests are
> discouraged from CodeGen, and this seems very similar.
> I think the preferred option would be to make sure any test you
> believe it's usefully doing is part of the test/MC hierarchy.
> Cheers.
> Tim.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131202/7232d167/attachment.html>

More information about the llvm-commits mailing list