[lld] r196056 - Fix "doesnot", "endsup" typos and "lets" grammar issues

Alp Toker alp at nuanti.com
Sun Dec 1 17:28:14 PST 2013


Author: alp
Date: Sun Dec  1 19:28:14 2013
New Revision: 196056

URL: http://llvm.org/viewvc/llvm-project?rev=196056&view=rev
Log:
Fix "doesnot", "endsup" typos and "lets" grammar issues

Modified:
    lld/trunk/lib/Driver/GnuLdDriver.cpp
    lld/trunk/lib/Passes/LayoutPass.cpp
    lld/trunk/lib/ReaderWriter/ELF/File.h
    lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h
    lld/trunk/lib/ReaderWriter/ELF/Reader.cpp
    lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
    lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h
    lld/trunk/test/elf/tlsAddr.test

Modified: lld/trunk/lib/Driver/GnuLdDriver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/GnuLdDriver.cpp?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/Driver/GnuLdDriver.cpp (original)
+++ lld/trunk/lib/Driver/GnuLdDriver.cpp Sun Dec  1 19:28:14 2013
@@ -316,7 +316,7 @@ bool GnuLdDriver::parse(int argc, const
       StringRef userPath = inputArg->getValue();
       std::string resolvedInputPath = userPath;
 
-      // If the path was referred to by using a -l argument, lets search
+      // If the path was referred to by using a -l argument, let's search
       // for the file in the search path.
       if (isDashlPrefix) {
         ErrorOr<StringRef> resolvedPath = ctx->searchLibrary(userPath);

Modified: lld/trunk/lib/Passes/LayoutPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Passes/LayoutPass.cpp?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/Passes/LayoutPass.cpp (original)
+++ lld/trunk/lib/Passes/LayoutPass.cpp Sun Dec  1 19:28:14 2013
@@ -227,14 +227,14 @@ void LayoutPass::buildFollowOnTable(Muta
       const DefinedAtom *targetAtom = dyn_cast<DefinedAtom>(r->target());
       _followOnNexts[ai] = targetAtom;
 
-      // If we find a followon for the first time, lets make that atom as the
+      // If we find a followon for the first time, let's make that atom as the
       // root atom.
       if (_followOnRoots.count(ai) == 0)
         _followOnRoots[ai] = ai;
 
       auto iter = _followOnRoots.find(targetAtom);
       if (iter == _followOnRoots.end()) {
-        // If the targetAtom is not a root of any chain, lets make the root of
+        // If the targetAtom is not a root of any chain, let's make the root of
         // the targetAtom to the root of the current chain.
         _followOnRoots[targetAtom] = _followOnRoots[ai];
       } else if (iter->second == targetAtom) {

Modified: lld/trunk/lib/ReaderWriter/ELF/File.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/File.h?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/File.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/File.h Sun Dec  1 19:28:14 2013
@@ -431,7 +431,7 @@ public:
           if (previousAtom)
             createEdge(anonAtom, previousAtom,
                        lld::Reference::kindLayoutBefore);
-          // If this is the last atom, lets not create a followon reference.
+          // If this is the last atom, let's not create a followon reference.
           if (anonAtom && (si + 1) != se) {
             anonFollowedBy = new (_readerStorage) ELFReference<ELFT>(
                 lld::Reference::kindLayoutAfter);
@@ -443,7 +443,7 @@ public:
             symbolName, *sectionName, &*symbol, section, symbolData);
         newAtom->setOrdinal(++_ordinal);
 
-        // If the atom was a weak symbol, lets create a followon reference to
+        // If the atom was a weak symbol, let's create a followon reference to
         // the anonymous atom that we created.
         if (anonAtom)
           createEdge(newAtom, anonAtom, lld::Reference::kindLayoutAfter);

Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonSectionChunks.h Sun Dec  1 19:28:14 2013
@@ -42,7 +42,7 @@ public:
     uint64_t align2 = 1u << atomAlign.powerOf2;
     this->_atoms.push_back(new (this->_alloc) lld::AtomLayout(atom, 0, 0));
     // Set the section alignment to the largest alignment
-    // std::max doesnot support uint64_t
+    // std::max doesn't support uint64_t
     if (this->_align2 < align2)
       this->_align2 = align2;
     return *(this->_atoms.back());

Modified: lld/trunk/lib/ReaderWriter/ELF/Reader.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Reader.cpp?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Reader.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Reader.cpp Sun Dec  1 19:28:14 2013
@@ -102,8 +102,8 @@ public:
       break;
     }
     case llvm::sys::fs::file_magic::elf_shared_object: {
-      // If the link doesnot allow dynamic libraries to be present during the
-      // link, lets not parse the file and just return
+      // If the link doesn't allow dynamic libraries to be present during the
+      // link, let's not parse the file and just return
       if (!_elfLinkingContext.allowLinkWithDynamicLibraries())
         return llvm::make_error_code(llvm::errc::executable_format_error);
       auto f = createELF<DynamicFileCreateELFTraits>(

Modified: lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h Sun Dec  1 19:28:14 2013
@@ -333,7 +333,7 @@ const lld::AtomLayout &AtomSection<ELFT>
     break;
   }
   // Set the section alignment to the largest alignment
-  // std::max doesnot support uint64_t
+  // std::max doesn't support uint64_t
   if (this->_align2 < align2)
     this->_align2 = align2;
 
@@ -886,7 +886,7 @@ public:
   virtual void finalize() {
     // Defined symbols which have been added into the dynamic symbol table
     // don't have their addresses known until addresses have been assigned
-    // so lets update the symbol values after they have got assigned
+    // so let's update the symbol values after they have got assigned
     for (auto &ste: this->_symbolTable) {
       const lld::AtomLayout *atomLayout = ste._atomLayout;
       if (!atomLayout)
@@ -1207,7 +1207,7 @@ public:
   }
 
   // The size of the section has to be determined so that fileoffsets
-  // may be properly assigned. Lets calculate the buckets and the chains
+  // may be properly assigned. Let's calculate the buckets and the chains
   // and fill the chains and the buckets hash table used by the dynamic
   // linker and update the filesize and memory size accordingly
   virtual void doPreFlight() {

Modified: lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/SegmentChunks.h Sun Dec  1 19:28:14 2013
@@ -297,7 +297,7 @@ protected:
 };
 
 /// \brief A Program Header segment contains a set of chunks instead of sections
-/// The segment doesnot contain any slice
+/// The segment doesn't contain any slice
 template <class ELFT> class ProgramHeaderSegment : public Segment<ELFT> {
 public:
   ProgramHeaderSegment(const ELFLinkingContext &context)
@@ -456,7 +456,7 @@ template <class ELFT> void Segment<ELFT>
       }
       uint64_t newOffset = llvm::RoundUpToAlignment(curOffset, (*si)->align2());
       SegmentSlice<ELFT> *slice = nullptr;
-      // If the newOffset computed is more than a page away, lets create
+      // If the newOffset computed is more than a page away, let's create
       // a separate segment, so that memory is not used up while running
       if (((newOffset - curOffset) > this->_context.getPageSize()) &&
           (_outputMagic != ELFLinkingContext::OutputMagic::NMAGIC &&
@@ -569,10 +569,10 @@ template <class ELFT> void Segment<ELFT>
       if (isTLSSegment)
         tlsStartAddr += section->memSize();
       section->setMemSize(addr + section->memSize() - section->virtualAddr());
-      // TBSS section is special that it doesnot contribute to memory of any
-      // segment, If we see a tbss section, don't add memory size to addr
+      // TBSS section is special in that it doesn't contribute to memory of any
+      // segment. If we see a tbss section, don't add memory size to addr
       // The fileOffset is automatically taken care of since TBSS section does
-      // not endup using file size
+      // not end up using file size
       if (section->order() != DefaultLayout<ELFT>::ORDER_TBSS)
         addr += section->memSize();
     }

Modified: lld/trunk/test/elf/tlsAddr.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/tlsAddr.test?rev=196056&r1=196055&r2=196056&view=diff
==============================================================================
--- lld/trunk/test/elf/tlsAddr.test (original)
+++ lld/trunk/test/elf/tlsAddr.test Sun Dec  1 19:28:14 2013
@@ -1,5 +1,5 @@
 # This tests verifies that TLS variables have correct offsets
-# and that TBSS doesnot occupy memory 
+# and that TBSS doesn't occupy memory
 RUN: lld -flavor gnu -target x86_64-linux %p/Inputs/tlsAddr.x86-64 -static  \
 RUN: -o %t --noinhibit-exec
 RUN: llvm-objdump -section-headers %t | FileCheck -check-prefix=CHECKADDR %s





More information about the llvm-commits mailing list