Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents

Rafael EspĆ­ndola rafael.espindola at gmail.com
Sat Nov 30 07:14:14 PST 2013


What is the issue that you see, BYTE_ORDER is not defined? Is
Support/Solaris.h being included?

On 30 November 2013 07:38, Samuel Marks <samuelmarks at hotmail.com> wrote:
> Well I was getting an error on Solaris until I applied this patch.
>
> So it seems that revision didn't fix the problem for me. This patch is based on a bunch of other code which is in production; from reputable sources (such as LevelDB).
>
> ----------------------------------------
>> Date: Wed, 13 Nov 2013 15:30:24 -0500
>> Subject: Re: Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents
>> From: rafael.espindola at gmail.com
>> To: samuelmarks at hotmail.com
>> CC: llvm-commits at cs.uiuc.edu
>>
>> Isn't this redundant given r182419?
>>
>> On 8 November 2013 08:11, Samuel Marks <samuelmarks at hotmail.com> wrote:
>>> nbjoerg didn't like the OS_* notation; so I've reverted to the other notation and added a few more specialisations.
>>>
>>> ----------------------------------------
>>> From: samuelmarks at hotmail.com
>>> To: llvm-commits at cs.uiuc.edu
>>> Subject: RE: Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents
>>> Date: Fri, 8 Nov 2013 22:31:51 +1100
>>>
>>>
>>> *attached
>>> ----------------------------------------
>>>> From: samuelmarks at hotmail.com
>>>> To: llvm-commits at cs.uiuc.edu
>>>> Subject: RE: Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents
>>>> Date: Fri, 8 Nov 2013 22:08:38 +1100
>>>>
>>>> *Attached
>>>> ----------------------------------------
>>>>> From: samuelmarks at hotmail.com
>>>>> To: llvm-commits at cs.uiuc.edu
>>>>> Subject: RE: Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents
>>>>> Date: Fri, 8 Nov 2013 22:07:54 +1100
>>>>>
>>>>> Hmm, actually it might be better to copy how they managed it in the ChromiumOS project (LevelDB ppl); patch attached.
>>>>>
>>>>> See https://chromium.googlesource.com/chromiumos/third_party/leveldb/+/master/port/port_posix.h
>>>>>
>>>>> ----------------------------------------
>>>>> From: samuelmarks at hotmail.com
>>>>> To: llvm-commits at cs.uiuc.edu
>>>>> Subject: RE: Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents
>>>>> Date: Wed, 6 Nov 2013 20:34:09 +1100
>>>>>
>>>>>
>>>>> Somehow lost `|| defined(__GNU__)` from the end of `#elif defined(__linux__)`; please see revised patch (attached)
>>>>>
>>>>> From: samuelmarks at hotmail.com
>>>>> To: llvm-commits at cs.uiuc.edu
>>>>> Subject: Patch for `include/llvm/Support/Host.h` to support BSD and Solaris endian.h equivalents
>>>>> Date: Wed, 6 Nov 2013 09:02:54 +0000
>>>>>
>>>>> Please see attached.
>>>>>
>>>>> Note that this PATCH has been stolen from http://permalink.gmane.org/gmane.network.dns.powerdns.devel/1172 šŸ˜œ
>>>>>
>>>>> Tested on Sun OS 5.10 (SPARC).
>>>>>
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>




More information about the llvm-commits mailing list