[PATCH] Fix the failure exposed by checking constant integer argument range
t.p.northover at gmail.com
Tue Nov 26 23:34:57 PST 2013
> The C test case changes can show this clearly. Previously, all the test case
> only pass constant 0 or 1 as the lane argument.
Thanks for the examples Jiangning. I'd fiddled with a couple of them,
but obviously happened to pick cases that already worked so got myself
> Here, if we don't remove the concat_vectors at lowering stage, we would have
> to explicitly describe concat_vectors in the pattern being matched.
> Otherwise, we would fail to combine fneg and fma to be a fms.
Ah, that makes sense. I think these look fine then.
More information about the llvm-commits