[PATCH] switch ARM modes in inline asm
garious at gmail.com
Mon Nov 25 12:43:48 PST 2013
I'm starting to think that fixing this bug is a bad idea and that reporting an error might be more appropriate. Fixing the bug opens up a can of worms. Say the user's inline assembly doesn't return to thumb mode. Should the compiler inject the $t mapping symbol? Should it inject a ".code 16" directive? Should it inject a label and adr to switch back to thumb mode? Where do we draw the line?
Also, my test is fragile. That $a shouldn't be displayed by llvm-objdump (and isn't by GNU's objdump). Also, the CHECK-NEXT assertions are checking those bytes in the context of thumb instructions. Instead there should just be one CHECK that matches all 4 bytes on one line.
More information about the llvm-commits