[PATCH] ARM: refactor redundant *_dyn pseudos

Renato Golin renato.golin at linaro.org
Mon Nov 25 05:55:36 PST 2013

  Hi Tim,

  Apart from my comment below, the change looks good to me.

Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:819
@@ -815,1 +818,3 @@
+    // flag the global as MO_NONLAZY.
   } else if (ACPV->isMachineBasicBlock()) {
The implicit contract that the callee will deal with the NONLAZY only when in Darwin mode is not ideal.

I think, even this being Darwin specific and all, it would be more clear to use something like:

DarwinLazy = isDarwin ? ARMII::MO_NONLAZY : 0;
MCSym = GetARMGVSymbol(GV, DarwinLazy);

even if this is slightly redundant with what GetARMGVSymbol() does, it's a lot clearer to the reader.


More information about the llvm-commits mailing list