[PATCH] Making Type::getScalarSizeInBits() const

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sun Nov 24 20:04:46 PST 2013


LGTM

On 21 November 2013 12:41, Marcello Maggioni <marcello at codeplay.com> wrote:
> Hi, while using this function I noticed that Type::getScalarSizeInBits() is
> not marked as const even if inside its body it just uses only other "const"
> functions and types.
> This prevents the usage of the function through const pointers/references to
> Type without any apparent reason.
>
> I propose of marking the function as const. (attached is a patch that does
> so).
>
> Cheers,
> Marcello
>
> --
> Marcello Maggioni
>
> Compiler Engineer
>
>
> Codeplay Software Ltd
>
> 45 York Place, Edinburgh, EH1 3HP
>
> Tel: 0131 466 0503
>
> Fax: 0131 557 6600
>
> Website: http://www.codeplay.com
>
> Twitter: https://twitter.com/@codeplaybiz
>
>
> This email and any attachments may contain confidential and /or privileged
> information and  is for use  by the addressee only. If you are not the
> intended recipient, please notify Codeplay Software Ltd immediately and
> delete the message from your computer. You may not copy or forward it,or use
> or disclose its contents to any other person. Any views or other information
> in this message which do not relate to our business are not authorized by
> Codeplay software Ltd, nor does this message form part of any contract
> unless so stated.
>
> As internet communications are capable of data corruption Codeplay Software
> Ltd does not accept any responsibility for any changes made to this message
> after it was sent. Please note that Codeplay Software Ltd does not accept
> any liability or responsibility for viruses and it is your responsibility to
> scan any attachments.
>
> Company registered in England and Wales, number: 04567874
>
> Registered office: 81 Linkfield Street, Redhill RH1 6BY
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list