[PATCH] Re-enable movw/movt on iOS static platforms

Renato Golin renato.golin at linaro.org
Fri Nov 22 10:54:01 PST 2013


Hi Tim,

Two issues on LowerGlobalAddressDarwin:
 - You can now remove the FIXME. ;)
 - That condition seems to be change for non-Darwin, too, if that's the
case, do we have tests for those?

I can't comment on the Darwin side, but coming from you, I guess it's
correct. ;)

cheers,
--renato



On 22 November 2013 13:44, Tim Northover <t.p.northover at gmail.com> wrote:

> Hi all (well, mostly Apple people),
>
> There's a bit of code to generate movw/movt for static Darwin targets
> that's been dead in ARMISelLowering since 2011, and I think it's time
> we did something about it.
>
> Apparently some tools didn't like the static movw/movt relocations,
> but I believe those issues are now no longer relevant
> (rdar://problem/9514789). For uniformity I'd quite like to re-enable
> it, though removing it completely is another option.
>
> The patch re-enables it.
>
> OK to commit?
>
> Cheers.
>
> Tim.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131122/6e4cd5fc/attachment.html>


More information about the llvm-commits mailing list