[PATCH] Fix PR18014

Nadav Rotem nrotem at apple.com
Fri Nov 22 09:53:34 PST 2013


LGTM! 

On Nov 22, 2013, at 9:42 AM, Michael Liao <michael.liao at intel.com> wrote:

> Hi All,
> 
> The attached patch fixes PR18014 which is caused by an over optimization
> in x86 DAG combining. To generate efficient code for BLEND, we simplify
> the mask generation by only ensure to generate the MSB. If that mask is
> also consumed by other non-BLEND insns, the code is broken. This patch
> checks whether that mask is only consumed by BLEND eventually and skip
> if it's not true.
> 
> Thanks for review
> 
> Yours
> - Michael
> <0001-Fix-PR18014.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list