[PATCH][AArch64]Fix the Cygwin build failure caused by questionable enum values in AArch64BaseInfo.h

Hao Liu Hao.Liu at arm.com
Fri Nov 22 02:31:05 PST 2013


Hi Tim,

Thanks for the review. This patch is committed in
http://llvm.org/viewvc/llvm-project?view=revision&revision=195432.

But I don't how to merge code to branch 3.4. 
The log of branch3.4 is like:
       r1 | void |
 
       Merging r0:
        ------------------------------
       r0 | userID | ...

Should I just patch my code to branch3.4 and commit it? 
Or there are some special rules I must follow?

Thanks,
-Hao 

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Tim Northover
Sent: Friday, November 22, 2013 4:16 AM
To: Bill Wendling
Cc: llvm-commits; Eric Niebler
Subject: Re: [PATCH][AArch64]Fix the Cygwin build failure caused by
questionable enum values in AArch64BaseInfo.h

> I don't have the patch to look at. It sounds like a refactoring patch,
though. I'm fine with it going in if it helps and doesn't change
functionality.

Yep. It's just "rename a bunch of enumerators so that they don't start with
"_[A-Z]". Thanks Bill.

Could you do the merge onto 3.4 Hao?

Thanks

Tim.

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits







More information about the llvm-commits mailing list