[PATCH][AArch64]Fix the Cygwin build failure caused by questionable enum values in AArch64BaseInfo.h

Bill Wendling isanbard at gmail.com
Thu Nov 21 12:12:03 PST 2013


On Nov 21, 2013, at 2:10 AM, Tim Northover <t.p.northover at gmail.com> wrote:

> Hi Hao (& Bill),
> 
>> This simple patch renams such values and will solve the problem. As this
>> patch only renames the values in enum, we don't need any additional test
>> cases. As this is only a very simple patch, I don't know whether it needs
>> code review.
>> 
>> If it is OK, I'll commit it to the trunk.
> 
> This looks fine, and I'd have been completely happy for you to commit
> and go for post-commit review on something like this. Fixing a build
> is very important.
> 
> Bill: I'd like to put this onto the 3.4 branch please, would that be
> OK with you? It should be extremely low risk.
> 
Hi Tim,

I don’t have the patch to look at. It sounds like a refactoring patch, though. I’m fine with it going in if it helps and doesn’t change functionality.

-bw






More information about the llvm-commits mailing list