[PATCH] Implement the ldr-pseudo opcode for ARM assembly

[David Peixotto]

Hi Jim,

 

I had thought that these set of tests would be ok because I was using the
machine independent assembler apis, but I can see that I have made a bad
assumption. I will add the corresponding tests for darwin.

 

(As an aside, I just tried a quick test with the first example from
ldr-pseudo.s and it did not complain about the labels. I'm used the same
commands, but switched the target to armv7-darwin-apple and updated the
.section syntax. In any case I will fix the labels to use real temporaries,
but let me know if there is a better way to test for darwin).

 

As for the subsections-via-symbols, I had looked for a test that I could
follow, but did not see anything. Based on our discussion it seems that
pc-relative loads across symbols is undefined behavior. So even the existing
ldr <label> instructions should have a problem, right? Is there some test
you can point me to that checks for this or some testing guidance you can
provide? I'm not quite sure what the correct behavior should be here.

 

-David

 

 

From: Jim Grosbach [mailto:grosbach at apple.com] 
Sent: Tuesday, November 19, 2013 4:56 PM
To: David Peixotto
Cc: Commit Messages and Patches for LLVM
Subject: Re: [PATCH] Implement the ldr-pseudo opcode for ARM assembly

 

Hi David,

 

As far as I can tell, these patches don't handle the subsections-via-symbols
or anything else Darwin related at all. Am I missing something? For a
trivial example, the label names are not going to work at all on Darwin.

 

-Jim

 

On Nov 15, 2013, at 6:00 PM, David Peixotto <dpeixott at codeaurora.org> wrote:





Attached are 3 patches that together implement the ldr pseudo for arm and
the .ltorg directive. Please help to review these patches.

 

Thanks,

David

 

-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
by The Linux Foundation

 

 

<0001-Add-a-finishParse-callback-to-the-targer-asm-parser.patch><0002-Implem
ent-the-ldr-pseudo-opcode-for-ARM-assembly.patch><0003-Implement-the-.ltorg-
directive-for-ARM-assembly.patch>___________________________________________
____
llvm-commits mailing list
 <mailto:llvm-commits at cs.uiuc.edu> llvm-commits at cs.uiuc.edu
 <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131119/a5ab9648/attachment.html>