[PATCH] Generalize debug info / EH emission in AsmPrinter

Reid Kleckner rnk at google.com
Tue Nov 19 13:31:43 PST 2013


  Seems fine, but let Dave or Eric comment.


================
Comment at: lib/CodeGen/AsmPrinter/DebugInfoEmitter.h:25
@@ +24,3 @@
+
+class DebugInfoEmitter {
+public:
----------------
Is this the right name to abstract over codeview line tables, various EH impls, and general debug info?  IMO it deserves a doc comment to explain what kind of thing might implement one of these.


http://llvm-reviews.chandlerc.com/D2222



More information about the llvm-commits mailing list