[PATCH] Implement the ldr-pseudo opcode for ARM assembly

[Renato Golin]

On 19 November 2013 02:50, Bill Wendling <isanbard at gmail.com> wrote:

> Adding a few people so that they can give this a looking at.
>

Hi David, Bill,

Sorry it took so long, I'm looking at it now... Would be good to get the
comments of as many people as we can, since this may be a sensitive issue
to some.

Some early comments:

The ConstantPool object is creating as many labels as there are symbols in
the constant pool, will that get merged later?

Overall, looks good, but there is no check if the constant pools will be
accessible from the instructions that use it, since they're just dumped at
the end of each section. That might work for most cases, but would be good
to at least add a FIXME somewhere.

I'll look at the test cases in more detail later, but it's good that there
are many of them. ;)

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131119/85cb2463/attachment.html>