[PATCH] Write references to Native format in NativeReferenceIvarsV2.

Rui Ueyama ruiu at google.com
Mon Nov 18 10:42:31 PST 2013


How could you fix it with V1? Relocation targets are stored
in NCS_TargetsTable chunk, but the index (targetIndex in
NativeReferenceIvarsV1) pointing to an item in the chunk has only 16
bits. That's the limitation of NativeReferenceIvarsV1 format. It seems that
we have no choice other than using a data structure having bigger integer
for the taget table indices.

As to addend, please look at the definition of NativeReferenceIvarsV2.
"addend" field is defined as int64_t, which is big enough to directly store
addend. So we should eliminate the indirection for addend for saving disk
space, memory and for runtime efficiency.


On Mon, Nov 18, 2013 at 10:29 AM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

>
>   This should be fixed with V1. I dont think there is a need for V2 at
> this time. I couldnot follow the changes behind the addendsTableIndex ? is
> this part of a different cleanup ?
>
> http://llvm-reviews.chandlerc.com/D2217
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131118/042e4602/attachment.html>


More information about the llvm-commits mailing list