[PATCH] Loop Rerolling Pass
atrick at apple.com
Fri Nov 15 19:11:06 PST 2013
On Nov 15, 2013, at 4:55 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> Andy, you had said that you did not object to me committing this and working on it in-tree. Can I take that as permission? Really, I don't want to commit a bunch of unreadable code, but I think it is better at this point, and I'd appreciate it if you (or anyone else), would take a quick look and provide some feedback on whether it looks reviewable.
Yep, I don’t want to hold this up. It's a lot easier to develop major functionality in-tree. I’ll send post-commit comments if I have any more.
> Thanks again,
> ----- Original Message -----
>> ----- Original Message -----
>>> This should address the remainder of the initial review comments.
>>> I've factored out the reduction tracking into its own class, and
>>> made a number of other improvements. I've added more function
>>> documentation, including documentation on the overall algorithm.
>>> Hopefully, this is more reviewable now.
>>> To be clear, the pass-manager change is only there to ease
>>> and would not be committed in this way.
>>> Thanks again!
>>> Hi nadav, rengolin, atrick,
>>> CHANGE SINCE LAST DIFF
>> Hal Finkel
>> Assistant Computational Scientist
>> Leadership Computing Facility
>> Argonne National Laboratory
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
More information about the llvm-commits