[llvm] r194538 - Introduce an AnalysisManager which is like a pass manager but with a lot

[Aaron Ballman]

On Fri, Nov 15, 2013 at 5:00 PM, Chandler Carruth <chandlerc at gmail.com> wrote:
> Thanks for the review!

My pleasure!

>
> On Fri, Nov 15, 2013 at 6:21 AM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> This is causing crashes in MSVC debug builds due to being an invalid
>> iterator operation. Specifically, when I == ResultsList.begin(),
>> attempting to decrement walks off the front of the iterator list.
>
>
> Doh, thanks. Fixed in r194857.
>
>>
>>
>> Once I correct the issue locally, I get several new failing unit tests:
>
>
> I think these are unrelated -- they aren't failing for me after fixing.

I think you're right, I was likely in a goofy state.  Your fix
resolved the issues I was seeing.

Thanks!

~Aaron