[lld] r194851 - [PECOFF] Remove unnecessary static member.

Rui Ueyama ruiu at google.com
Fri Nov 15 13:12:11 PST 2013


Author: ruiu
Date: Fri Nov 15 15:12:11 2013
New Revision: 194851

URL: http://llvm.org/viewvc/llvm-project?rev=194851&view=rev
Log:
[PECOFF] Remove unnecessary static member.

Modified:
    lld/trunk/lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp

Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp?rev=194851&r1=194850&r2=194851&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderImportHeader.cpp Fri Nov 15 15:12:11 2013
@@ -150,35 +150,28 @@ namespace coff {
 
 namespace {
 
+uint8_t FuncAtomContent[] = {
+  0xff, 0x25, 0x00, 0x00, 0x00, 0x00,  // jmp *0x0
+  0x90, 0x90                           // nop; nop
+};
+
 /// The defined atom for jump table.
 class FuncAtom : public COFFLinkerInternalAtom {
 public:
   FuncAtom(const File &file, StringRef symbolName)
-      : COFFLinkerInternalAtom(file, std::vector<uint8_t>(rawContent),
-                               symbolName) {}
+      : COFFLinkerInternalAtom(
+            file,
+            std::vector<uint8_t>(FuncAtomContent,
+                                 FuncAtomContent + sizeof(FuncAtomContent)),
+            symbolName) {}
 
   virtual uint64_t ordinal() const { return 0; }
   virtual Scope scope() const { return scopeGlobal; }
   virtual ContentType contentType() const { return typeCode; }
   virtual Alignment alignment() const { return Alignment(1); }
   virtual ContentPermissions permissions() const { return permR_X; }
-
-private:
-  static std::vector<uint8_t> rawContent;
 };
 
-// MSVC doesn't seem to like C++11 initializer list, so initialize the
-// vector from an array.
-namespace {
-uint8_t FuncAtomContent[] = {
-  0xff, 0x25, 0x00, 0x00, 0x00, 0x00,  // jmp *0x0
-  0x90, 0x90                           // nop; nop
-};
-} // anonymous namespace
-
-std::vector<uint8_t> FuncAtom::rawContent(
-    FuncAtomContent, FuncAtomContent + sizeof(FuncAtomContent));
-
 class FileImportLibrary : public File {
 public:
   FileImportLibrary(const LinkingContext &context,





More information about the llvm-commits mailing list