[PATCH] Path: Recognize COFF import library file magic.

Rafael Espíndola rafael.espindola at gmail.com
Fri Nov 15 13:05:52 PST 2013

On 15 November 2013 15:58, Rui Ueyama <ruiu at google.com> wrote:
> ================
> Comment at: test/tools/llvm-readobj/file-headers.test:210
> @@ +209,3 @@
> +COFF-IMPORTLIB-NEXT:   SectionCount: 65535
> +COFF-IMPORTLIB-NEXT:   TimeDateStamp: 1970-09-09 19:52:32 (0x14C0000)
> ----------------
> Rafael Ávila de Espíndola wrote:
>> Should we special case to not print this? If the file has no sections, we should probably just not print this line.
> Yeah we shouldn't, but I guess it's out of scope of this patch -- this is for identifying COFF import library file as a COFF file. llvm-readobj cannot really handle import library yet. It reads the header as a regular COFF object and skips everything else. I'm planning to extend llvm-readobj to handle such files properly but it's not going to be in this patch.



More information about the llvm-commits mailing list