[PATCH] Path: Recognize COFF import library file magic.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Nov 15 12:53:19 PST 2013



================
Comment at: test/tools/llvm-readobj/file-headers.test:210
@@ +209,3 @@
+COFF-IMPORTLIB-NEXT:   Machine: IMAGE_FILE_MACHINE_UNKNOWN (0x0)
+COFF-IMPORTLIB-NEXT:   SectionCount: 65535
+COFF-IMPORTLIB-NEXT:   TimeDateStamp: 1970-09-09 19:52:32 (0x14C0000)
----------------
Should we special case to not print this? If the file has no sections, we should probably just not print this line.

================
Comment at: test/tools/llvm-readobj/file-headers.test:213
@@ +212,3 @@
+COFF-IMPORTLIB-NEXT:   PointerToSymbolTable: 0x528542EB
+COFF-IMPORTLIB-NEXT:   SymbolCount: 20
+COFF-IMPORTLIB-NEXT:   OptionalHeaderSize: 0
----------------
The symbols are real, right? Can you pass -symbols to llvm-readobj and check them too?


http://llvm-reviews.chandlerc.com/D2165



More information about the llvm-commits mailing list