[PATCH] Avoid illegal integer promotion in X86FastISel

[Bob Wilson]

Thanks.  Committed in 194840.

On Nov 15, 2013, at 9:58 AM, Eric Christopher <echristo at gmail.com> wrote:

> Sorry, missed this... LGTM :)
> 
> -eric
> 
> On Fri, Nov 15, 2013 at 7:35 AM, Duncan P. N. Exon Smith
> <dexonsmith at apple.com> wrote:
>> [ping]
>> 
>> 
>> 
>> 
>> On 2013 Nov 11, at 18:06, Duncan Exon Smith <dexonsmith at apple.com> wrote:
>> 
>>> Hi Eric,
>>> 
>>> Thanks for the review!
>>> 
>>> On Nov 11, 2013, at 5:19 PM, Eric Christopher <echristo at gmail.com> wrote:
>>> 
>>>> Might want to elaborate with the actual conditions in the comment.
>>>> Also sentences end in a period.
>>> 
>>> Fixed.
>>> 
>>>> +bool FastISel::canFoldAddIntoGEP(const User *GEP, const Value *Add)
>>>> +{
>>> 
>>> My bad.
>>> 
>>>> +  if (TD.getTypeSizeInBits(GEP->getType()) !=
>>>> +      TD.getTypeSizeInBits(Add->getType()))
>>>> 
>>>> +  if (isa<Instruction>(Add) &&
>>>> +      FuncInfo.MBBMap[cast<Instruction>(Add)->getParent()] != FuncInfo.MBB)
>>>> 
>>>> The indenting doesn't look quite right here.
>>>> 
>>>> Meta: clang-format would have fixed all of these for sure. :)
>>> 
>>> clang-format agreed with me for these. ;)
>>> 
>>>> +; RUN: llc %s -O0 -o - | FileCheck %s
>>>> +
>>>> +target triple = "armv7-apple-ios"
>>>> 
>>>> Go ahead and fold the triple into RUN line for all of these.
>>> 
>>> Take 3 attached.  Have another look?
>>> 
>>> <fastisel-illegal-promotion-3.patch>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits